Add Taggable class#51
Merged
Merged
Conversation
inducer
reviewed
Nov 20, 2020
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! Some comments below. Also, could you make a PR to make pytato use this?
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
Co-authored-by: Andreas Klöckner <inform@tiker.net>
2 tasks
Contributor
Author
|
@inducer I think this is ready for another look. |
1 task
inducer
reviewed
Nov 24, 2020
Owner
Propose tag uniqueness check algorithm
Owner
|
Could you document the |
Contributor
Author
Done! |
inducer
reviewed
Jan 5, 2021
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! A few more wrinkles below.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
approved these changes
Jan 6, 2021
inducer
left a comment
inducer
left a comment
Owner
There was a problem hiding this comment.
@nchristensen As I said during our meeting, this is good to merge from my end, but I'll wait per our conversation until you've restated the tests in terms of the ribbons from your demo.
Contributor
Author
|
@inducer Done! |
inducer
approved these changes
Jan 9, 2021
Owner
|
Thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in inducer/loopy#173